Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add classname attribute to junit xml report #229

Merged
merged 2 commits into from
Jul 10, 2024
Merged

feat: add classname attribute to junit xml report #229

merged 2 commits into from
Jul 10, 2024

Conversation

kenibrewer
Copy link
Contributor

@kenibrewer kenibrewer commented Jul 10, 2024 •
edited
Loading

This adds the classname attribute to the testcase elements in the junit xml report.

Closes #228

@kenibrewer kenibrewer marked this pull request as ready for review July 10, 2024 13:13
@kenibrewer
Copy link
Contributor Author

@lukfor This is ready for ready for review

@aaron-fishman-achillestx Tagging you because this builds on your previous PR.

lukfor
lukfor reviewed Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@lukfor lukfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. See comment. 🙏

@kenibrewer kenibrewer requested a review from lukfor July 10, 2024 14:54
@lukfor lukfor merged commit c7a0a61 into askimed:main Jul 10, 2024
6 checks passed
@lukfor
Copy link
Collaborator

lukfor commented Jul 10, 2024

Thanks for your help 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukfor lukfor Awaiting requested review from lukfor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add classname attribute to testcase in junit xml output
2 participants
@kenibrewer @lukfor