Skip to content

Commit

Permalink
test: update a broken test due to PRs race (envoyproxy#35671)
Browse files Browse the repository at this point in the history
Commit Message: test: update a broken test due to PRs race
Additional Description:
PR envoyproxy#35568 used an old `setup()` method call which was modified by PR
envoyproxy#35209 that was merged just before it, causing a build failure.
This PR update the test and fixes the build failure.

Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: asingh-g <[email protected]>
  • Loading branch information
adisuissa authored and asingh-g committed Aug 20, 2024
1 parent 5bbb8c6 commit 754c415
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/common/http/conn_manager_impl_test_2.cc
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ TEST_F(HttpConnectionManagerImplTest, DrainConnectionUponCompletionVsOnDrainTime
Event::MockTimer* connection_duration_timer = setUpTimer();
EXPECT_CALL(*connection_duration_timer, enableTimer(_, _));
// Set up connection.
setup(false, "");
setup();

// Create a filter so we can encode responses.
MockStreamDecoderFilter* filter = new NiceMock<MockStreamDecoderFilter>();
Expand Down

0 comments on commit 754c415

Please sign in to comment.