Fix error when app is set to use CarbonImmutable #285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #284.
Recap: Currently the package breaks if your app has configured the
Date
facade to useCarbonImmutable
instead ofCarbon
(as per this blog post by Michael Dyrynda).To get it working is a one-line fix - changing one instance of
now()
toCarbon::now()
in theBuilder
class.Some comments/caveats:
datetime
properties on Eloquent models contain an object of the correct class (eitherCarbon
orCarbonImmutable
, depending on how you've configured theDate
facade), no matter what was used to set them.ShortURL
andShortURLVisit
models are incorrect: all references toCarbon
there should beCarbon|CarbonImmutable
. Would changing those doc blocks be a breaking change? Otherwise I can change those as well.CarbonImmutable
... not sure that's worth doing!Hope this is an improvement on the last effort.