Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added asdf-bitwarden-secrets-manager to infrastructure #81

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

FIAV1
Copy link
Contributor

@FIAV1 FIAV1 commented Sep 19, 2023

No description provided.

@FIAV1 FIAV1 requested a review from a team as a code owner September 19, 2023 17:18
@smorimoto
Copy link
Member

I thought about this again, but isn't the name of this repository a little too generic? I think something like the bitwarden secrets manager would be better.

@FIAV1
Copy link
Contributor Author

FIAV1 commented Sep 20, 2023

That's right, I was thinking about it too, i'm gonna fix the naming all around and update pull requests

@FIAV1
Copy link
Contributor Author

FIAV1 commented Sep 20, 2023

btw, do I also have to submit a PR to asdf-plugins repo to add the shortname or is it sufficient to follow the guidelines for this community repo?

@FIAV1 FIAV1 changed the title Added asdf-secrets-manager to infrastructure Added asdf-bitwarden-secrets-manager to infrastructure Sep 20, 2023
@smorimoto
Copy link
Member

For shortname support, you need to open a new PR in that repository...

@smorimoto smorimoto merged commit 5e0877d into asdf-community:main Sep 27, 2023
3 checks passed
@smorimoto
Copy link
Member

Anyway, thanks @FIAV1!

@FIAV1 FIAV1 deleted the patch-2 branch September 27, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants