Upgrade prawn-svg #2469
Merged
Upgrade prawn-svg #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Three of the visual tests are failing. However, when I inspect the changes manually, I cannot perceive any difference, so likely it is some sort of rounding difference. Therefore, I'll update the expected output files and proceed. |
adds support for the dominant-baseline SVG attribute to make text center-aligned
mojavelinux
force-pushed
the
upgrade-prawn-svg
branch
from
54c2ed9
to
9bc843b
Compare
|
OK. Thanks for your help! |
mojavelinux
pushed a commit
that referenced
this pull request
Dec 18, 2023
adds support for the dominant-baseline SVG attribute to make text center-aligned
|
Hi @mojavelinux , is it possible to upgrade the version of the release recently? I want to update the dependency of my project. Thank you! |
|
I don't have any plans for an immediate release, but once I come back around to the project and make a few other updates, I'll push out a release. |
|
OK. I'll wait for the release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm using bytefield-svg which is heavily using the
dominant-baselineof SVG attribute to make the texts center-aligned. However, prawn-svg cannot recognize the attribute. Therefore, I made a PR to support the feature, and it has been merged into main branch successfully. Moreover, the newest release 0.33.0 has included the feature. I hope the asciidoctor-pdf can upgrade it as well.Thank you!