feat: New Output Plugin Microsoft Fabric #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhishek-saharn
changed the title
ag-ramachandran
requested changes
Oct 15, 2024
| ConnectionString := m.ConnectionString | ||
|
|
||
| if ConnectionString == "" { | ||
| return errors.New("endpoint must not be empty") |
There was a problem hiding this comment.
We should mention this example as: For Kusto refer : https://learn.microsoft.com/en-us/kusto/api/connection-strings/kusto?view=microsoft-fabric for EventStream refer : https://learn.microsoft.com/en-us/fabric/real-time-intelligence/event-streams/add-manage-eventstream-sources?pivots=enhanced-capabilities
| m.EHConf.Log = m.Log | ||
| m.EHConf.Init() | ||
| m.FabricSinkService = m.EHConf | ||
| } else { |
There was a problem hiding this comment.
Should we check for DataSource = and make it explicit for Kusto, throw an error otherwise. Because we can say extend to one lake later
| outputs.Add("microsoft_fabric", func() telegraf.Output { | ||
| return &MicrosoftFabric{ | ||
| ADXConf: &ADX.AzureDataExplorer{ | ||
| Timeout: config.Duration(20 * time.Second), |
There was a problem hiding this comment.
Timeout should be configurable
There was a problem hiding this comment.
Yes. Timeout is configurable. this is default. as per the corresponding connector.
asaharn
changed the title
asaharn
force-pushed
the
feature/microsoft_fabric
branch
from
0e8da79
to
73c913c
Compare
|
Moved change to #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Related issues
resolves #