Support padding in renderImg
#51
Conversation
mariusandra
changed the title
renderImg
src/QRgen/renderer.nim
Outdated
| padding: uint8 = 5, | ||
| img: Image = Image(width: 0, height: 0), | ||
| imgCoords: tuple[x, y, w, h: uint8] = self.genDefaultCoords |
There was a problem hiding this comment.
I think it would be better if you made the new parameter the last one, so that backwards compatibility remains, although I actually like it more were you left it.
There was a problem hiding this comment.
That makes sense, moved it to the end.
|
Seems like I have to fix the GH actions haha (what did I expect after ~1.5y), I hope you can wait a bit, I will try to work on it tomorrow. |
|
Cool, thanks for taking it on so quickly. The workaround known as "copy paste" does the job for now 😅, so no there's rush from my side. |
|
Seems like it was just the version of the GH actions, I'm merging this directly to avoid the hassle of getting you to merge my develop onto your branch. |
|
Release 3.1.0 with this PR has been released! Although I no longer maintain this repo, PRs are always welcome :) |
|
Thanks again! I updated my deps and could now remove the copy pasta. Also 🙌 for keeping up the maintenance work! |
When adding QR code support to my own project, I had to tweak
renderImgto support customizable amounts of padding around the code.