Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the reference colours consistent between runs and/or have some control over reference colour. #56

Open
aineniamh opened this issue Jan 14, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@aineniamh
Copy link
Member

Potentially by indexing reference colour from the sample sheet rather than order of appearance in csv or making it customisable like the sample colours.

@aineniamh aineniamh added the enhancement New feature or request label Jan 14, 2020
@jameshadfield
Copy link
Member

making it customisable like the sample colours

It is (or was). Let me look into this...

@rambaut
Copy link
Member

rambaut commented Jan 14, 2020

We had a talk about this and think the solution is to have a references_config.json or some similar name which optionally contains a list of reference names (possibly colours and other labels). If this list exists then those references are always shown in the heatmap and are given the same colours.

@rambaut rambaut self-assigned this Jan 14, 2020
@jameshadfield
Copy link
Member

jameshadfield commented Jan 14, 2020

You should be able to change sample / ref colours in the UI. But that doesn't really address this issue. (I plan to work on this today.)

Our current implementation (by design) means that RAMPART doesn't know about the references FASTA -- I guess the path is saved in the config object, but it's intended as simply a parameter passed to the annotation script. As "new" references appear in the annotation results, rampart updates its display (and currently generates a new colour). Not sure what's the best design here, as I do think that consistency between runs is desirable.

@rambaut
Copy link
Member

rambaut commented Jan 14, 2020

Yes. That is what I meant. We should have an optional config in the protocol folder which allows you to pre-specify the set of reference names (perhaps a mapping to a higher taxonomic order - i.e. a genotype), an ordering and a colour (optioning). If this is present then all of these references are present in heatmap (even if zero reads). I would prefer to avoid rampart reading and parsing fasta files.

@rambaut
Copy link
Member

rambaut commented Jan 14, 2020

Another option would be to hash the reference name rampart sees it and take some bits of the hash to index the colour?

@rambaut
Copy link
Member

rambaut commented Jan 14, 2020

I also think we don't need colour editing in GUI for references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants