Change to overlap-based method of amplicon resolution #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the amplicon (/primer pair) assigned to a read is determined in order to be:
a) a little more transparent
b) work more sensibly for fragmented amplicons
It also separates out the writing of the bam from the read selection to allow more sophisticated read selection post filtering.
Things proceed as follows,
First pass:
1b) Allow some filtering options based on nature of overlap
The reads are the downsampled per (amplicon, orientation), selecting reads preferentially on their span of the amplicon.
Second pass: