Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes find_primers to search in the appropriate direction for left or right primers. In particular, this fix helps when using the Rapid Barcoding Kit. More reads are assigned the correct primer pair and group number, leading to more reads being used in consensus sequence generation.
The function find_primer searches, in both 5' and 3' directions, for the nearest primer to a position on a given strand. This causes issues with using the Nanopore Rapid Barcoding Kit, which makes reads that begin in the middle of amplicons. These reads are assigned the wrong primer pairs and are filtered out.
The correction is to add a condition to the list comprehension and (p['start'] - pos <= 0).