👷 Build also for Windows

Also add build as release target in CI

.github/workflows/ci.yml

@@ -10,15 +10,20 @@ env:
   CARGO_TERM_COLOR: always
 
 jobs:
-  test:
-    runs-on: ubuntu-latest
+  build_and_test:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-lastest, windows-latest]
     steps:
     - uses: actions/checkout@v4
       with:
         submodules: true
     - uses: Swatinem/rust-cache@v2
-    - name: Build
+    - name: Build debug
       run: cargo build --verbose
+    - name: Build release
+      run: cargo build --verbose --release
     - name: Run tests no default features
       run: cargo test --no-default-features
     - name: Run tests

quickfix-ffi/build.rs

@@ -73,10 +73,24 @@ fn main() {
         "cargo:rustc-link-search=native={}/lib",
         quickfix_bind_dst.display()
     );
-    println!("cargo:rustc-link-lib=static=quickfix");
+
+    if matches!(env::var("PROFILE").as_deref(), Ok("debug"))
+        && matches!(env::var("CARGO_CFG_TARGET_OS").as_deref(), Ok("windows"))
+    {
+        // libquickfix as a different name on windows with debug profile.
+        println!("cargo:rustc-link-lib=static=quickfixd");
+    } else {
+        println!("cargo:rustc-link-lib=static=quickfix");
+    }
+
     println!("cargo:rustc-link-lib=static=quickfixbind");
-    println!("cargo:rustc-link-lib=stdc++");
 
+    // Lib std C++ is only available on UNIX platform.
+    if env::var("CARGO_CFG_UNIX").is_ok() {
+        println!("cargo:rustc-link-lib=stdc++");
+    }
+
+    // Link with external libraries if needed.
     if have_feature("build-with-mysql") {
         println!("cargo:rustc-link-lib=mysqlclient");
     }

quickfix-ffi/quickfix-bind/CMakeLists.txt

@@ -4,7 +4,14 @@ include_directories(include)
 add_library(quickfixbind STATIC
     src/quickfix_bind.cpp
 )
-target_link_libraries(quickfixbind ${MYSQL_CLIENT_LIBS} ${PostgreSQL_LIBRARIES} quickfix)
+target_link_libraries(quickfixbind ${MYSQL_CLIENT_LIBS} ${PostgreSQL_LIBRARIES})
+
+if (WIN32)
+    target_link_libraries(quickfixbind debug quickfixd)
+    target_link_libraries(quickfixbind optimized quickfix)
+else()
+    target_link_libraries(quickfixbind quickfix)
+endif()
 
 # Add option if asked
 if (WITH_PRINT_EX_STDOUT)

quickfix-ffi/quickfix-bind/include/quickfix_bind.h

@@ -133,7 +133,7 @@ FixMessage_t *FixMessage_fromStringAndDictionary(const char *text, const FixData
 const char *FixMessage_getField(const FixMessage_t *obj, int32_t tag);
 int8_t FixMessage_setField(FixMessage_t *obj, int32_t tag, const char *value);
 int8_t FixMessage_removeField(FixMessage_t *obj, int32_t tag);
-int8_t FixMessage_toBuffer(const FixMessage_t *obj, char *buffer, size_t length);
+int8_t FixMessage_toBuffer(const FixMessage_t *obj, char *buffer, uint64_t length);
 void FixMessage_delete(const FixMessage_t *obj);
 
 FixHeader_t *FixMessage_copyHeader(const FixMessage_t *obj);

quickfix-ffi/quickfix-bind/src/quickfix_bind.cpp

@@ -595,7 +595,7 @@ int8_t FixMessage_removeField(Message *obj, int32_t tag) {
   });
 }
 
-int8_t FixMessage_toBuffer(const Message *obj, char *buffer, size_t length) {
+int8_t FixMessage_toBuffer(const Message *obj, char *buffer, uint64_t length) {
   if (length == 0)
     return 0;
 

quickfix-ffi/src/lib.rs

@@ -317,11 +317,7 @@ extern "C" {
     pub fn FixMessage_removeField(obj: FixMessage_t, tag: i32) -> i8;
 
     #[must_use]
-    pub fn FixMessage_toBuffer(
-        obj: FixMessage_t,
-        buffer: *mut ffi::c_char,
-        length: ffi::c_long,
-    ) -> i8;
+    pub fn FixMessage_toBuffer(obj: FixMessage_t, buffer: *mut ffi::c_char, length: u64) -> i8;
     pub fn FixMessage_delete(obj: FixMessage_t);
 
     // Header

quickfix/src/message.rs

@@ -43,7 +43,7 @@ impl Message {
     pub fn as_string_with_len(&self, max_len: usize) -> Result<String, QuickFixError> {
         let mut buffer = vec![0_u8; max_len];
         let buffer_ptr = buffer.as_mut_ptr() as *mut i8;
-        match unsafe { FixMessage_toBuffer(self.0, buffer_ptr, max_len as i64) } {
+        match unsafe { FixMessage_toBuffer(self.0, buffer_ptr, max_len as u64) } {
             0 => Ok(read_buffer_to_string(&buffer)),
             code => Err(QuickFixError::InvalidFunctionReturnCode(code)),
         }