➕ Make log crate optional

.github/workflows/ci.yml

@@ -20,6 +20,8 @@ jobs:
 
     - name: Build
       run: cargo build --verbose
+    - name: Run tests no default features
+      run: cargo test --no-default-features
     - name: Run tests
       run: cargo test
 

quickfix/Cargo.toml

@@ -4,13 +4,14 @@ version = "0.1.0"
 edition = "2021"
 
 [dependencies]
-log = "0.4.20"
 quickfix-ffi = { path = "../quickfix-ffi" }
 thiserror = "1.0.50"
+log = { version = "0.4.20", optional = true }
 
 [dev-dependencies]
 colored = "2.0.4"
 
 [features]
-default = []
+default = ["log"]
 print-ex = ["quickfix-ffi/print-ex"]
+log = ["dep:log"]

quickfix/src/lib.rs

@@ -21,7 +21,7 @@ pub use error::QuickFixError;
 pub use file_store_factory::FileStoreFactory;
 pub use group::Group;
 pub use header::Header;
-pub use log_factory::{LogCallback, LogFactory, RustLogger, StdLogger};
+pub use log_factory::{LogCallback, LogFactory, StdLogger};
 pub use message::Message;
 pub use session::send_to_target;
 pub use session_id::SessionId;
@@ -30,6 +30,9 @@ pub use socket_acceptor::SocketAcceptor;
 pub use socket_initiator::SocketInitiator;
 pub use trailer::Trailer;
 
+#[cfg(feature = "log")]
+pub use log_factory::RustLogger;
+
 pub trait ConnectionHandler {
     fn start(&mut self) -> Result<(), QuickFixError>;
     fn block(&mut self) -> Result<(), QuickFixError>;

quickfix/src/log_factory.rs

@@ -116,8 +116,10 @@ impl LogCallback for StdLogger {
     }
 }
 
+#[cfg(feature = "log")]
 pub struct RustLogger;
 
+#[cfg(feature = "log")]
 impl LogCallback for RustLogger {
     fn on_incoming(&self, session_id: Option<&SessionId>, msg: &str) {
         log::info!("FIX: Incoming: {session_id:?}: {msg}");

quickfix/tests/test_lifecycle.rs

@@ -1,6 +1,4 @@
-use quickfix::{
-    FileStoreFactory, LogFactory, QuickFixError, RustLogger, SessionSettings, StdLogger,
-};
+use quickfix::{FileStoreFactory, LogFactory, QuickFixError, SessionSettings, StdLogger};
 
 #[test]
 fn test_session_settings() {
@@ -13,12 +11,19 @@ fn test_session_settings() {
 }
 
 #[test]
-fn test_file_log_factory() {
-    let _file_log_factory = LogFactory::try_new(&RustLogger).unwrap();
+fn test_log_factory() {
     let _file_log_factory = LogFactory::try_new(&StdLogger::Stdout).unwrap();
     let _file_log_factory = LogFactory::try_new(&StdLogger::Stderr).unwrap();
 }
 
+#[test]
+#[cfg(feature = "log")]
+fn test_extra_log_factory() {
+    use quickfix::RustLogger;
+
+    let _file_log_factory = LogFactory::try_new(&RustLogger).unwrap();
+}
+
 #[test]
 fn test_file_store_factory() {
     let settings = SessionSettings::try_from_path("../example/settings.ini").unwrap();