Fix extracting references from regex match #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex uses separate capture groups for alternative expressions that match a single-quoted or a double-quoted string. This is more robust with strings that may contain quotes. However the code using the match objects doesn't currently take the two capture groups into account and always expects the results in group 1, which only matches double-quoted strings. This change introduces a check so that if group 1 is None, the function will use the matched substring in group 2. Closes arthepsy#36
|
I ran across #36 while updating as well, and this PR fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex uses separate capture groups for alternative expressions that match a single-quoted or a double-quoted string. This is more robust with strings that may contain quotes.
However the code using the match objects doesn't currently take the two capture groups into account and always expects the results in group 1, which only matches double-quoted strings.
This change introduces a check so that if group 1 is None, the function will use the matched substring in group 2.
Closes #36