Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to split a tuple for debug output #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

keis
Copy link

@keis keis commented Jan 27, 2022

Add tuple to the list of types that should not be split()

@arthepsy
Copy link
Owner

LGTM. Anyhow, can You elaborate in what situation this happens?

@keis
Copy link
Author

keis commented Jan 27, 2022

It happens when trying to use webauthn with debug on

!!! Touch the flashing U2F device to authenticate... !!!
Traceback (most recent call last):
  File "/home/keis/src/github.com/arthepsy/pan-globalprotect-okta/./gp-okta.py", line 660, in okta_mfa_webauthn
    dbg(conf.debug, 'assertion.result', result)
  File "/home/keis/src/github.com/arthepsy/pan-globalprotect-okta/./gp-okta.py", line 130, in dbg
    for line in x.split('\n'):
AttributeError: 'tuple' object has no attribute 'split'

This is with fido2==0.7.0 so before the API change that's mentioned in #33

@coldcoff
Copy link
Contributor

@arthepsy: That change is good. It's useful for #33 but unrelated.

@coldcoff
Copy link
Contributor

@arthepsy -- please merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants