Rearrange packages to be vertically grouped rather than layered #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #209 Package structure: Vertical over horizontal slicing
Here's a first-go at organizing packages vertically by feature rather than layered by type.
There's still some low-level layer package (e.g. network) which I think is fine as long as it isn't specifically related to an application feature.
The
otherpackage containingEntityTypeAdapterFactoryalong withApplicationModuleandModelsModulein the top package seem like they could be in amodulespackage name to mean assembly, dependency injection, or something to that effect.The
performanceandsubscriptionalso seem like related task handling facility.In all vertically looks much simpler and easier to work with. Here's a screenshot.
[I couldn't test build/run just now on my platform as my java version is 12 and gradle/build-scan seem to have issues with it around "Could not set unknown property 'licenseAgreementUrl' for com.gradle.scan.plugin...".]