Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize styling of the various search icons #297

Merged
merged 4 commits into from
Oct 22, 2018

Conversation

Cliabhach
Copy link
Contributor

@Cliabhach Cliabhach commented Oct 19, 2018

This does not significantly modify the layout of any such ImageView; note that this work is primarily intended to lay the groundwork for tasks related to #298 (right now, PR #291 and PR #299 are the best examples of that).

@@ -161,6 +169,22 @@ class AccessMemberCardFragment : BaseViewModelFragment<AccessMemberCardViewModel
.disposedBy(disposeBag)
}

override fun setupNavigationBindings(viewModel: AccessMemberCardViewModel) {
super.setupNavigationBindings(viewModel)
viewModel.navigateTo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical blocks of code found in 4 locations. Consider refactoring.

@Cliabhach
Copy link
Contributor Author

Cliabhach commented Oct 22, 2018

@caguilar187 If you have a moment today, I'd appreciate your eyes on this. It shouldn't be terribly controversial.

@caguilar187 caguilar187 merged commit f53b375 into dev Oct 22, 2018
@Cliabhach Cliabhach deleted the pc-standardize-search-button-execution branch May 24, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants