Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Welcome: Standardize usage of 'Cell' ViewModels #291

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

WIP: Welcome: Standardize usage of 'Cell' ViewModels #291

wants to merge 14 commits into from

Commits on Nov 20, 2018

  1. [Refactor] - Welcome: Use the same CellViewModels for both home and… 

    … `all`

This removes a decent amount of code duplication.
    @Cliabhach
    Cliabhach committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    dd31145 View commit details
    Browse the repository at this point in the history

  2. [Refactor] - AllTours: remove obsolete color-setting code

    @Cliabhach
    Cliabhach committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    afeb663 View commit details
    Browse the repository at this point in the history

  3. [AllEvents] - Refactor: don't request an options menu, as we won't us… 

    …e it
    @Cliabhach
    Cliabhach committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    4fe20f9 View commit details
    Browse the repository at this point in the history

  4. [Documentation] - Welcome: add class-level docs to the 3 All fragments

    @Cliabhach
    Cliabhach committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    ae2884b View commit details
    Browse the repository at this point in the history

  5. [ContentListing] - Refactor: rename one of the AllToursItemDecoration… 

    ….kt files

I don't know why this wasn't caught earlier? Must've not been
reviewed properly.
    @Cliabhach
    Cliabhach committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    9b595ec View commit details
    Browse the repository at this point in the history

  6. [ContentListing] - Refactor: move some files to a new, dedicated package

    @Cliabhach
    Cliabhach committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    a2f0bb0 View commit details
    Browse the repository at this point in the history

  7. [ContentListing] - Refactor: remove two minor rounding operations in … 

    …ATID
    @Cliabhach
    Cliabhach committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    21475c7 View commit details
    Browse the repository at this point in the history

  8. [ContentListing] - Refactor: convert two position vars into vals 

    With this, all of the local variables in the `decoration` package are
immutable.
    @Cliabhach
    Cliabhach committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    a5cf78c View commit details
    Browse the repository at this point in the history

  9. [ContentListing] - Documentation: actually attribute those files to t… 

    …he author
    @Cliabhach
    Cliabhach committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    c9cf5de View commit details
    Browse the repository at this point in the history

  10. [ContentListing] - Refactor: inline safe assumptions about the decora… 

    …tion code
    @Cliabhach
    Cliabhach committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    f6bbd7e View commit details
    Browse the repository at this point in the history

  11. [Refactor] - Use prebuilt Rect::setEmpty instead of `Rect::set(0,0,… 

    …0,0)`
    @Cliabhach
    Cliabhach committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    69664c9 View commit details
    Browse the repository at this point in the history

  12. [ContentListing] - Create new base class for the three decorations

    @Cliabhach
    Cliabhach committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    dd1ae24 View commit details
    Browse the repository at this point in the history

  13. [ContentListing] - Use that new class to late-initialize dimensions

    @Cliabhach
    Cliabhach committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    7bc8850 View commit details
    Browse the repository at this point in the history

  14. [ContentListing] - Remove now-unneccessary constructor parameter

    @Cliabhach
    Cliabhach committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    e4eead8 View commit details
    Browse the repository at this point in the history