-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Welcome: Standardize usage of 'Cell' ViewModels #291
Open
Cliabhach
wants to merge
14
commits into
dev
Choose a base branch
from
pc-standardize-usage-of-cell-view-models
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 20, 2018
-
[Refactor] - Welcome: Use the same CellViewModels for both
home
and…… `all` This removes a decent amount of code duplication.
Configuration menu - View commit details
-
Copy full SHA for dd31145 - Browse repository at this point
Copy the full SHA dd31145View commit details -
Configuration menu - View commit details
-
Copy full SHA for afeb663 - Browse repository at this point
Copy the full SHA afeb663View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fe20f9 - Browse repository at this point
Copy the full SHA 4fe20f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae2884b - Browse repository at this point
Copy the full SHA ae2884bView commit details -
[ContentListing] - Refactor: rename one of the AllToursItemDecoration…
….kt files I don't know why this wasn't caught earlier? Must've not been reviewed properly.
Configuration menu - View commit details
-
Copy full SHA for 9b595ec - Browse repository at this point
Copy the full SHA 9b595ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for a2f0bb0 - Browse repository at this point
Copy the full SHA a2f0bb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21475c7 - Browse repository at this point
Copy the full SHA 21475c7View commit details -
[ContentListing] - Refactor: convert two
position
vars into valsWith this, all of the local variables in the `decoration` package are immutable.
Configuration menu - View commit details
-
Copy full SHA for a5cf78c - Browse repository at this point
Copy the full SHA a5cf78cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9cf5de - Browse repository at this point
Copy the full SHA c9cf5deView commit details -
Configuration menu - View commit details
-
Copy full SHA for f6bbd7e - Browse repository at this point
Copy the full SHA f6bbd7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69664c9 - Browse repository at this point
Copy the full SHA 69664c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd1ae24 - Browse repository at this point
Copy the full SHA dd1ae24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bc8850 - Browse repository at this point
Copy the full SHA 7bc8850View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4eead8 - Browse repository at this point
Copy the full SHA e4eead8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.