-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert wildfly-arquillian-container to 4.0.1.Final #207
Conversation
The failed checks are both caused by github internal errors:
@rhusar Do you have a chance to rerun them? According to the web, there should be buttons to do so, but either I don't have the necessary privileges, or they are not supported here. |
a6c5079
to
e638aca
Compare
Helped myself ("git commit --amend" with empty message, then "git push --force") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you! I couldn't for the love of me figure out what was going wrong 🤦🏼
I didn't give this a lot of thought, as per your comment here #141 (comment) which was hinting that the only problem was JDK 11 while the real problem is really the Jakarta EE 10 upgrade in that integration. My bad!
Yes, I have an option to rerun them too |
Yes, that's the best solution that I know of. If the |
@WolfgangHG Also, just when it comes to git, the correct way to form this PR was really to revert the individual commits, i.e.
and resolve conflicts as they come up. The repository no longer uses squash merging. |
This also needs a dependabot ignore section update so that it will not open things like #141 - i ll add it now. |
Resolves #203
"wildfly-arquillian-container-managed" 5.0 does not seem to be compatible with WildFly 26 / JavaEE8 and breaks dependency injection.
This is a temporary fix. After updating to JakartaEE10, we have to go to 5.0 again.