Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert wildfly-arquillian-container to 4.0.1.Final #207

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

WolfgangHG
Copy link
Contributor

Resolves #203

"wildfly-arquillian-container-managed" 5.0 does not seem to be compatible with WildFly 26 / JavaEE8 and breaks dependency injection.

This is a temporary fix. After updating to JakartaEE10, we have to go to 5.0 again.

@WolfgangHG
Copy link
Contributor Author

The failed checks are both caused by github internal errors:

Download action repository 'actions/setup-java@v4' (SHA:b36c23c0d998641eff861008f374ee103c25ac73)
Warning: Failed to download action 'https://internal-api.service.iad.github.net/repos/actions/setup-java/tarball/b36c23c0d998641eff861008f374ee103c25ac73'. Error: Name or service not known (internal-api.service.iad.github.net:443)
Warning: Back off 25.075 seconds before retry.
Warning: Failed to download action 'https://internal-api.service.iad.github.net/repos/actions/setup-java/tarball/b36c23c0d998641eff861008f374ee103c25ac73'. Error: Name or service not known (internal-api.service.iad.github.net:443)
Warning: Back off 11.253 seconds before retry.
Error: Name or service not known (internal-api.service.iad.github.net:443)

@rhusar Do you have a chance to rerun them? According to the web, there should be buttons to do so, but either I don't have the necessary privileges, or they are not supported here.

@WolfgangHG
Copy link
Contributor Author

Helped myself ("git commit --amend" with empty message, then "git push --force")

Copy link
Collaborator

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! I couldn't for the love of me figure out what was going wrong 🤦🏼

I didn't give this a lot of thought, as per your comment here #141 (comment) which was hinting that the only problem was JDK 11 while the real problem is really the Jakarta EE 10 upgrade in that integration. My bad!

@rhusar
Copy link
Collaborator

rhusar commented Sep 26, 2024

The failed checks are both caused by github internal errors:

Download action repository 'actions/setup-java@v4' (SHA:b36c23c0d998641eff861008f374ee103c25ac73)
Warning: Failed to download action 'https://internal-api.service.iad.github.net/repos/actions/setup-java/tarball/b36c23c0d998641eff861008f374ee103c25ac73'. Error: Name or service not known (internal-api.service.iad.github.net:443)
Warning: Back off 25.075 seconds before retry.
Warning: Failed to download action 'https://internal-api.service.iad.github.net/repos/actions/setup-java/tarball/b36c23c0d998641eff861008f374ee103c25ac73'. Error: Name or service not known (internal-api.service.iad.github.net:443)
Warning: Back off 11.253 seconds before retry.
Error: Name or service not known (internal-api.service.iad.github.net:443)

@rhusar Do you have a chance to rerun them? According to the web, there should be buttons to do so, but either I don't have the necessary privileges, or they are not supported here.

Yes, I have an option to rerun them too

@rhusar
Copy link
Collaborator

rhusar commented Sep 26, 2024

Helped myself ("git commit --amend" with empty message, then "git push --force")

Yes, that's the best solution that I know of. If the main moved in the meantime, it's best to use git pull --rebase upstream main and then git push origin --force.

@rhusar rhusar merged commit 082b91f into arquillian:main Sep 26, 2024
8 checks passed
@rhusar
Copy link
Collaborator

rhusar commented Sep 26, 2024

@WolfgangHG Also, just when it comes to git, the correct way to form this PR was really to revert the individual commits, i.e.

git revert f0a79e34f7cb6ad0056e4c0e2fe4761709832f95
git revert 9316dea2e16012fa0834ac83fceab0bb11ed5a9b

and resolve conflicts as they come up. The repository no longer uses squash merging.

@rhusar
Copy link
Collaborator

rhusar commented Sep 26, 2024

This also needs a dependabot ignore section update so that it will not open things like #141 - i ll add it now.

@rhusar
Copy link
Collaborator

rhusar commented Sep 26, 2024

This also needs a dependabot ignore section update so that it will not open things like #141 - i ll add it now.

Done - #207

@WolfgangHG WolfgangHG deleted the wildflycontainer401 branch September 26, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unignore 2 tests ignored with move to JDK 11
2 participants