Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, update and automate generation of detailed_gene and summary_gene tables #2 #914

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pfpjs
Copy link

@pfpjs pfpjs commented Jan 23, 2019

My previous PR was getting Ensembl gene info from GRCh38 instead of GRCh37, this fixes that.
The column transcript_tsl / transcript_status was changed to transcript_gencode_basic - more info here.

Updated generated detailed_gene_table_v95 and summary_gene_table_v95 can be found here: https://drive.google.com/drive/u/0/folders/1q5geCRd0EPqGJcJQ0j2D_V0IO7Z0Q3vq

Apologies for the oversight regarding GRCh37 vs. GRCh38, I'm always bugging people to check genome build versions, and now it was my turn to get burned!

Addresses #902 and #912.

@pfpjs pfpjs changed the title Fix, update and automate generation of detailed_gene and summary_gene_tables Fix, update and automate generation of detailed_gene and summary_gene tables #2 Jan 23, 2019
@gmteunisse
Copy link

Great work! I just checked the updated gene tables on google drive, but the HGNC names seem to not have been updated yet, i.e. they do not match the table downloaded from HGNC in hgnc.query.pl. Using issue #902 as an example, CECR1 is now a previous symbol for ADA2 in the downloaded table, yet in summary_gene_table_v95 it is still the approved symbol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants