Add ability to leave replies to existing comments #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… replies and tests coverage
|
What do the rest think about this? |
|
It's been working quite well for me on Scribe |
|
@aroc are you going to merge this PR? it looks awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue in #17
We can separate comments in 2 categories: Comment and Reply.
Every Reply is a Comment, but the inverse is not true.
Also, a Reply cannot have replies and must belong to a Comment, which may have from 0 to N replies. ( IMHO, using the "side-comments" format, makes no sense to have more than 1 level of nesting, that's why a Reply can't be replied, but this can be discussed )
A Reply, and a Comment with no replies can be normally deleted and removed from the list, however, a Comment with at least one Reply, can be deleted, but cannot be removed. To do so, I've used the flag
deleted, that will display the message "Comment deleted by the author". This was the trickier part to solve for me and it's entirely open to discussion.Cheers ;)