Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor networking configuration logic #84

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Refactor networking configuration logic #84

merged 3 commits into from
Sep 18, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Sep 18, 2024

Description

Refactor networking configuration logic to make it as easy as possible.

Implementation Details

  • support for multiple interfaces which are being added to the bridge by default
  • wireless adaptors in STA mode are not added to the bride as this method is not supported
  • wireless adaptors in AP mode are added to wired bridge. hostapd is installed and enabled
  • whole configuration can be set back to armbian defaults, which is DHCP on all wired interfaces
  • while adding adaptor, it can be selected DHCP or fixed IP address
  • old code for setting AP has been removed

Testing Procedure

  • DHCP wired networking
  • fixed wired networking
  • wireless in STA mode
  • wireless in AP mode
  • reverting back to stock config

It was tested with various scenarios, by using Network Manager and systemd-netword networking. Further tests are needed to make this functionality beyond breaking.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@igorpecovnik igorpecovnik changed the title Netix Refactor networking configuration logic Sep 18, 2024
@Tearran Tearran merged commit a613848 into main Sep 18, 2024
1 check passed
@Tearran Tearran deleted the netix branch September 18, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants