Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added last login toggle #82

Merged

Conversation

Tearran
Copy link
Collaborator

@Tearran Tearran commented Sep 15, 2024

Description

This pull request implements a function to reduce clutter by disabling the display of the last login message when connected via SSH. It addresses issue armbian/build/pull/7154 from the armbian/build repository. The change is motivated by the desire to make SSH sessions cleaner by hiding this message, which can be unnecessary and distracting for users.

Issue reference: #78
Related documentation: Armbian Documentation

Implementation Details

  • Key changes introduced by this PR:

    • Added a command to sed that disables the display of the last login message by setting PrintLastLog to no in the SSH configuration file.
    • Added a toggle helper function and corresponding menu items to manage this setting.
  • Justification for the changes:

    • The PrintLastLog option can clutter SSH sessions with unnecessary information. Disabling it will streamline the user experience and reduce visual clutter.
  • Confirmation that no new external dependencies or modules have been introduced:

    • The changes only involve modifications to the SSH configuration and do not introduce new external dependencies.

Documentation Summary

  • Metadata Included:

    • Yes, the necessary metadata for modules, jobs, and runtime has been included in the code.
  • Document Generated:

    • The updated documentation was generated using armbian-configng --doc. The command was run to ensure README.md and other relevant documentation are up to date.

Testing Procedure

  • Test 1:

    • Description: Verified that the PrintLastLog setting is correctly updated in the SSH configuration file.
    • Results: The configuration file correctly reflects the change to PrintLastLog no and restarts the SSH service successfully.
  • Test 2:

    • Description: Tested toggling the setting via the new menu items.
    • Results: The setting was successfully toggled on and off, and the SSH service restarted appropriately to apply changes.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@Tearran Tearran linked an issue Sep 15, 2024 that may be closed by this pull request
@Tearran Tearran self-assigned this Sep 15, 2024
@Tearran Tearran added ready enhancement New feature or request labels Sep 15, 2024
@Tearran Tearran merged commit 9b27cb8 into main Sep 16, 2024
1 check passed
@Tearran Tearran deleted the 78-task-add-enable-disable-lastlog-when-connected-via-ssh branch September 16, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add enable / disable lastlog when connected via SSH
2 participants