Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate svg and gcode code from FormsUI #1102

Open
wants to merge 117 commits into
base: master
Choose a base branch
from

Conversation

RafaelEstevamReis
Copy link

I am in progress to make LaserGRBL functions accessible in linux and via command line
The main issue is that there are a lot of dependency in a lot of classes, is hard to isolate and test
To be able to do so I moved all non-UI stuff to two Library Projects and solved most of dependency problems trying to keep the changes minimal
I made all changes in small commits to be easier to follow

In summary I:

  • Separated Cyotek files from RasterConverter/Dithering to a new Lib Project
  • Separated non Forms files to a new Lib Project
    • CSV folder
    • CsPotrace folder
    • SvgConverter folder
    • SvgLibrary folder
    • GrblFile
    • GrblCommand
    • Autotrace folder

I understand if this PR is too big to be revised, let me know if I can help in the process as the new library can be improved and tested more easily without any changes in the UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants