Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creat Text form #1098

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Creat Text form #1098

wants to merge 1 commit into from

Conversation

Fossdal
Copy link

@Fossdal Fossdal commented Aug 15, 2020

Created "Create Text" form
it is an Copy of "RasterToLaserFrom" where i have added a textbox and font selection.
the preview is updated when you type text or select font

it solves issue #1065

@arkypita
Copy link
Owner

arkypita commented Oct 3, 2020

Hi, sorry for delay.
I really appreciate your job.

I saw you duplicated the raster import window. I understand, it was a good way to avoid inadvertently "breaking" something.
Unfortunately this now forces to have to keep 2 versions of the same form, this means that any added or modified features will have to be tweaked twice. Ditto for translations. Not a good solution.
Are you able to re-write your code to use only one form?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants