poly: small refactor and unit tests for SparsePolynomial
#868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
requested review from
Pratyush,
mmagician and
weikengchen
and removed request for
a team
tcoratger
commented
Nov 12, 2024
Comment on lines
140
to
144
| // Assert correct number of indeterminates | ||
| assert!( | ||
| term.1.iter().all(|(var, _)| *var < num_vars), | ||
| term.iter().all(|(var, _)| *var < num_vars), | ||
| "Invalid number of indeterminates" | ||
| ); |
There was a problem hiding this comment.
This assertion is moved to the beginning of the loop because we must check this at the start of the loop before doing any calculation (this allows us to panic earlier if necessary)
tcoratger
commented
Nov 12, 2024
Pratyush
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small refactoring and more unit tests to cover the implementation
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer