Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes final exp test for the CP curve #672

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fixes final exp test for the CP curve #672

merged 1 commit into from
Aug 31, 2023

Conversation

swasilyev
Copy link
Contributor

@swasilyev swasilyev commented Aug 31, 2023 •
edited
Loading

Description

Fixes CI for arkworks/curves

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@swasilyev swasilyev requested review from a team as code owners August 31, 2023 12:30
@swasilyev swasilyev requested review from Pratyush, mmagician and weikengchen and removed request for a team August 31, 2023 12:30
@Pratyush Pratyush merged commit af981f3 into arkworks-rs:master Aug 31, 2023
7 of 15 checks passed
aleasims pushed a commit to NilFoundation/arkworks-algebra that referenced this pull request Oct 18, 2023
@swasilyev @aleasims
fixes final exp test for the CP curve (arkworks-rs#672)
9690228
aleasims added a commit to NilFoundation/arkworks-algebra that referenced this pull request Oct 18, 2023
@aleasims
Revert "fixes final exp test for the CP curve (arkworks-rs#672)"
06c45f0 
This reverts commit 9690228.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush approved these changes

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swasilyev @Pratyush