Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pseduo-remove MapToCurve::new, renamed to check_parameters #627

Closed
wants to merge 11 commits into from
Closed

Pseduo-remove MapToCurve::new, renamed to check_parameters #627

wants to merge 11 commits into from

Commits on Mar 20, 2023

  1. Avoid unused subdirectories

    ¨Jeff committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    5c710c5 View commit details
    Browse the repository at this point in the history

  2. Pseduo-remove MapToCurve::new, renamed to test_parameters 

    MapToCurve::new seemingly originates from a more runtime oriented
elliptic curve crate:
https://github.com/armfazh/redox-ecc/blob/master/src/ellipticcurve.rs#L36

Arguably test_parameters should be inherent methods, invoked by whoever
defined the parameters, but maybe not?  I left the trait method for now.
    ¨Jeff committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    91891aa View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Update ec/src/hashing/curve_maps/wb.rs 

    Co-authored-by: Pratyush Mishra <[email protected]>
    @burdges @Pratyush
    burdges and Pratyush authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    8c31c53 View commit details
    Browse the repository at this point in the history

  2. Update ec/src/hashing/curve_maps/swu.rs 

    Co-authored-by: Pratyush Mishra <[email protected]>
    @burdges @Pratyush
    burdges and Pratyush authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    ebe0a41 View commit details
    Browse the repository at this point in the history

  3. Update ec/src/hashing/map_to_curve_hasher.rs 

    Co-authored-by: Pratyush Mishra <[email protected]>
    @burdges @Pratyush
    burdges and Pratyush authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    caf56c0 View commit details
    Browse the repository at this point in the history

  4. Update ec/src/hashing/curve_maps/swu.rs 

    Co-authored-by: Pratyush Mishra <[email protected]>
    @burdges @Pratyush
    burdges and Pratyush authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    40cdde9 View commit details
    Browse the repository at this point in the history

  5. Two more renames

    ¨Jeff committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    a05eb81 View commit details
    Browse the repository at this point in the history

  6. make rustfmt happier

    ¨Jeff committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    ae014ae View commit details
    Browse the repository at this point in the history

  7. Again rustfmt

    ¨Jeff committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    f01abb9 View commit details
    Browse the repository at this point in the history

  8. rustfmt is wrong on this one but whatever 

    rustfmt is wrong that f()? should be preferred over f() ?, as errors paths should often be highlighted, but nobody merged that fix yet, so whatever. 
rust-lang/rustfmt#5595
    @burdges
    burdges authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    e828f28 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2023

  1. Merge branch 'master' into jb_h2c

    @weikengchen
    weikengchen authored Apr 23, 2023
    Configuration menu
    Copy the full SHA
    d0083e6 View commit details
    Browse the repository at this point in the history