Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] updates to oneapi compiler documentation #263

Merged
merged 5 commits into from
Sep 9, 2023

Conversation

abagusetty
Copy link
Contributor

No description provided.

@cjknight
Copy link
Contributor

cjknight commented Sep 6, 2023

I think module loading and compilation example on this page should be updated, right?

https://docs.alcf.anl.gov/polaris/compiling-and-linking/oneapi-compiler/

@abagusetty
Copy link
Contributor Author

Yes, the details were updated in this PR already. Since there is no versioning involved in the module naming. The module instructions & compilation command remains the same. Changes are mostly cosmetic. Still working on the PR, will convert it into a draft. It was just hosted as a PR to view the final markdown webpage.

@abagusetty abagusetty marked this pull request as draft September 6, 2023 15:29
@abagusetty abagusetty marked this pull request as ready for review September 6, 2023 15:51
@cjknight
Copy link
Contributor

cjknight commented Sep 6, 2023

The oneapi-compiler page seems to tell users to load a special oneapi module path and then load the 'compiler' module. The sycl-polaris page instructs users to simply load the 'oneapi' module, which I believe is the one that you maintain.

@abagusetty
Copy link
Contributor Author

The oneapi-compiler page seems to tell users to load a special oneapi module path and then load the 'compiler' module. The sycl-polaris page instructs users to simply load the 'oneapi' module, which I believe is the one that you maintain.

Gotcha. I agree, it is just the result of bad naming conventions for the modules. The intent was to name oneapi/release for the release version (oneapi-compiler page) and the open-source (sycl-polaris page) version to be oneapi/upstream. And make oneapi/release as default. Please let me know if this clears the confusion or any other suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants