Skip to content

Commit

Permalink
Configure actions/upload-artifact action to upload required hidden files
Browse files Browse the repository at this point in the history
A breaking change was made in the 3.2.1 release of the "actions/upload-artifact" action, without doing a major version
bump as would be done in a responsibly maintained project. The action now defaults to not uploading "hidden" files.

The "Check Go Dependencies" and "Check npm Dependencies" templates use the "Licensed" tool to check for incompatible
dependency licenses. The dependencies license metadata cache used by Licensed is stored in a folder named `.licensed`.

In order to facilitate updates, the workflows of these templates upload the generated dependencies license metadata
cache as a workflow artifact when the current cache is found to be outdated.

The `.` at the start of the `.licensed` folder name causes it to now not be uploaded to the workflow artifact. In order
to catch such problems, the workflow configures the "actions/upload-artifact" action to fail if no files were uploaded.
So the workflow now fails:

Error: No files were found with the provided path: .licenses/. No artifacts will be uploaded.

The problem is fixed by disabling the "actions/upload-artifact" action's new behavior via the `include-hidden-files`
input. After this change, the workflows can once more upload the dependencies license metadata cache to a workflow
artifact as needed
  • Loading branch information
per1234 committed Sep 3, 2024
1 parent 3655d44 commit 40e8d9c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions workflow-templates/check-go-dependencies-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ jobs:
uses: actions/upload-artifact@v4
with:
if-no-files-found: error
include-hidden-files: true
name: dep-licenses-cache
path: .licenses/

Expand Down
1 change: 1 addition & 0 deletions workflow-templates/check-npm-dependencies-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ jobs:
uses: actions/upload-artifact@v3
with:
if-no-files-found: error
include-hidden-files: true
name: dep-licenses-cache
path: .licenses/

Expand Down

0 comments on commit 40e8d9c

Please sign in to comment.