Skip to content

Commit

Permalink
Remove unused job outputs from release workflows
Browse files Browse the repository at this point in the history
In a previous revision of the release workflows, the updated checksums were determined by the macOS notarization job and
then passed to the subsequent job via job outputs. That approach was changed during a later refactoring, but the code
that declares the job outputs was not removed at that time.

The checksum job output declaration code is now unused (and unusable since the checksum determination and output
definitions were removed) so it only makes the workflows more difficult to understand and maintain. For this reason, the
vestigial code is hereby removed from the workflows.
  • Loading branch information
per1234 committed Oct 14, 2024
1 parent 4393dba commit 0afb419
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 11 deletions.
6 changes: 0 additions & 6 deletions workflow-templates/publish-go-nightly-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,6 @@ jobs:
name: Notarize ${{ matrix.build.folder-suffix }}
runs-on: macos-latest
needs: create-nightly-artifacts

outputs:
checksum-darwin_amd64: ${{ steps.re-package.outputs.checksum-darwin_amd64 }}
checksum-darwin_arm64: ${{ steps.re-package.outputs.checksum-darwin_arm64 }}

permissions:
contents: read

Expand Down Expand Up @@ -165,7 +160,6 @@ jobs:
gon "${{ env.GON_CONFIG_PATH }}"
- name: Re-package binary
id: re-package
working-directory: ${{ env.DIST_DIR }}
# Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
run: |
Expand Down
1 change: 0 additions & 1 deletion workflow-templates/release-go-crosscompile-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ jobs:
gon "${{ env.GON_CONFIG_PATH }}"
- name: Re-package binary
id: re-package
working-directory: ${{ env.DIST_DIR }}
# Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
run: |
Expand Down
4 changes: 0 additions & 4 deletions workflow-templates/release-go-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ jobs:
name: Notarize ${{ matrix.build.folder-suffix }}
runs-on: macos-latest
needs: create-release-artifacts
outputs:
checksum-darwin_amd64: ${{ steps.re-package.outputs.checksum-darwin_amd64 }}
checksum-darwin_arm64: ${{ steps.re-package.outputs.checksum-darwin_arm64 }}
permissions:
contents: read

Expand Down Expand Up @@ -172,7 +169,6 @@ jobs:
gon "${{ env.GON_CONFIG_PATH }}"
- name: Re-package binary
id: re-package
working-directory: ${{ env.DIST_DIR }}
# Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
run: |
Expand Down

0 comments on commit 0afb419

Please sign in to comment.