-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize name of "Firmware Updater" #2176
Conversation
I see the "Arduino IDE" workflow run for this PR failed due to a test failure: https://github.com/arduino/arduino-ide/actions/runs/5906567394/job/16022857803?pr=2176#step:7:1016 This test failure also occurs on the https://github.com/arduino/arduino-ide/actions/runs/5909092994/job/16029290009#step:7:1016 So it is unrelated to the changes proposed in this pull request. |
Some magic started to happen in the CLI. The CLI version is pinned: arduino-ide/arduino-ide-extension/package.json Lines 174 to 179 in 5a76be3
Version The IDE tests expect to see the But I see something different:
It's already pointing to the RC. The quick fix is to update the version to the RC CLI. See #2178. The longer fix is to stop doing a remote fetch when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Some Arduino boards have a supplemental hardware module that provides functionality separate from the primary microcontroller the sketch program runs on. Enhancements or fixes to the firmware that runs on these supplemental modules may be made over time so it is important for the users of these boards to have an easy way to update the firmware. Arduino IDE provides a tool for doing this. At the time the tool was created, the poor choice was made to include the names of the specific modules it supported at the time in the tool's name. As was inevitable, that list has changed, rendering the tool name no longer accurate. The immediate problem is that support has been added for updating the "bridge" and radio module on the UNO R4 WiFi. That module is neither a "WiFi101" nor a "NINA", so the tool name does not reflect the support for the UNO R4 WiFi. More significant changes in the supported modules are under way and will be introduced in the next release: - Dropping support for the "WiFi101" module - Adding support for the module on the Portenta C33 board Rather than attempting to maintain a regularly changing and overly verbose name that includes the list of every supported module, it is better to use a name for the tool that only describes its general purpose, leaving the task of describing the specific supported modules to the documentation.
b75952f
to
015fcb7
Compare
Motivation
Some Arduino boards have a supplemental hardware module that provides functionality separate from the primary microcontroller the sketch program runs on.
Enhancements or fixes to the firmware that runs on these supplemental modules may be made over time so it is important for the users of these boards to have an easy way to update the firmware. Arduino IDE provides a tool for doing this.
At the time the tool was created, the poor choice was made to include the names of the specific modules it supported at the time in the tool's name. As was inevitable, that list has changed, rendering the tool name no longer accurate.
The immediate problem is that support has been added for updating the "bridge" and radio module on the UNO R4 WiFi (#2165, arduino/arduino-fwuploader#172). That module is neither a "WiFi101" nor a "NINA", so the tool name does not reflect the support for the UNO R4 WiFi.
More significant changes in the supported modules are under way and will be introduced in the next release:
Change description
Rather than attempting to maintain a regularly changing and overly verbose name that includes the list of every supported module, it is better to use a name for the tool that only describes its general purpose, leaving the task of describing the specific supported modules to the documentation.
Reviewer checklist