Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update electron+electron-builder #2168

Closed
wants to merge 2 commits into from
Closed

Conversation

kittaakos
Copy link
Contributor

Motivation

This PR updates the version of the electron and electron-builder dependencies. I created this PR as the first attempt to fix eclipse-theia/theia#12751.

Change description

This PR updates the dependencies to [email protected] and [email protected].

Other information

Related error messages and issues:

Gtk-Message: 15:40:49.964: Failed to load module "xapp-gtk3-module"
libva error: vaGetDriverNameByIndex() failed with unknown libva error, driver_name = (null)

(when started with --disable-gpu):

[55758:0725/145858.450066:ERROR:gpu_init.cc(453)] Passthrough is not supported, GL is swiftshader, ANGLE is 

To verify:

  • CI works,
  • after downloading and starting the tester build, verify the electron version:
    • Open the Dev Tools in IDE2 (Ctrl/⌘+Alt+I),
    • Open Console (with Esc) if not opened,
    • Type: navigator.userAgent, and press Enter.
    • It must be Electron/25.5.0. The rest could be different per OS:
Screenshot 2023-08-14 at 14 20 14

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added the topic: code Related to content of the project itself label Aug 14, 2023
@kittaakos kittaakos self-assigned this Aug 14, 2023
to fix flaky build

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos
Copy link
Contributor Author

I created this PR as the first attempt to fix eclipse-theia/theia#12751.

It does not fix anything.

@kittaakos kittaakos closed this Aug 15, 2023
@kittaakos kittaakos deleted the electron-update branch August 15, 2023 14:25
@kittaakos kittaakos added the conclusion: invalid Issue/PR not valid label Aug 15, 2023
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project and removed topic: code Related to content of the project itself labels Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck at loading screen
2 participants