Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 中文(繁體) ("Chinese (Traditional)") localization #2151

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

coby2023t
Copy link
Contributor

@coby2023t coby2023t commented Jul 25, 2023

Motivation

Community contributions of translations for the "Chinese Traditional" language have reached 84% coverage of the Arduino IDE-specific UI strings in the "Arduino IDE 2.0" project on the Transifex localization platform.

A "Chinese (Traditional) Language Pack for Visual Studio Code" language pack is available, which provides the ability to ship those translations to the Arduino IDE users in addition to the translations for the strings that originate from the Eclipse Theia IDE framework contained in the language pack.

Change description

This will add a "中文(繁體)" option to the "Language" menu in the Arduino IDE preferences, which will cause the strings in the IDE UI to be localized for "Chinese (Traditional)".

Other information

Provides a partial resolution for #712

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • [N/A] Docs have been added / updated (for bug fixes / features)

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @coby2023t. Thanks for your pull request.

Please provide a detailed explanation of the changes this pull request makes to the localization data in the i18n/zh_Hant.json and i18n/zh_TW.json files.

These files are automatically generated from the source data in the "Arduino IDE 2.0" project on the Transifex localization platform. So we don't ever expect that a pull request submitted by a human would touch these files. Translation contributions must be done via Transifex. The reason is that any translations contributed directly to this repository would be overridden on the next automated sync from Transifex.

@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Jul 25, 2023
@coby2023t
Copy link
Contributor Author

ide 2.0 lack lots of l10n packages for many languages, it's a good idea to keep people to use the way they familiar with as old days. little fix for my capable knowledge. I will try transifex for the po file.

@per1234
Copy link
Contributor

per1234 commented Jul 25, 2023

ide 2.0 lack lots of l10n packages for many languages

There is a related issue here: #1447

@per1234 per1234 changed the title i18n fix missing language support, translation fix Restore lexicographic ordering of items in i18n configurations Jul 26, 2023
@per1234 per1234 changed the title Restore lexicographic ordering of items in i18n configurations Add 中文(繁體) ("Chinese (Traditional)") localization Jul 26, 2023
coby2023t and others added 4 commits July 25, 2023 20:11
This will add a "中文(繁體)" option to the "Language" menu in the Arduino IDE preferences, which will cause the strings
in the IDE UI to be localized for "Chinese (Traditional)".

In addition to the translations for the strings that originate from the Eclipse Theia IDE framework provided by the
"Chinese (Traditional) Language Pack for Visual Studio Code" language pack, this will also utilize the translations of
the Arduino IDE-specific strings contributed by the community.
Contributions to the translations can only be made via the Transifex localization framework, from which they are
automatically pulled into this repository. Contributions made directly to the data files as was done by the previous
commit would be lost on the next Transifex pull.
A convention has been established of ordering the lists of locale-related items in the configurations used by the
project's internationalization system.

Items were inserted at inappropriate locations by a previous commit.
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I didn't get an indication that @coby2023t planned to update the PR according to my previous review, I went ahead and pushed a commit to remove the inappropriately submitted localization data:

3017a31

@coby2023t please do submit those translations via Transifex. Your contributions would be very welcome there. There is information about how to contribute translations here:

https://github.com/arduino/arduino-ide/blob/main/docs/contributor-guide/translation.md

Thanks in advance!

I also pushed some clean up commits to bring the quality of the contribution up to the standards of this project:

I have verified that the changes proposed here are correct and beneficial. I also tested them. So everything is now good from my perspective, but I will wait a while to offer @kittaakos the opportunity to also review before merging.

@kittaakos kittaakos self-requested a review July 26, 2023 06:34
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Thank you for the contribution, @coby2023t 👍


Please squash merge the changes. IDE2 does not need four commits in the history for this feature. Thank you!

@per1234 per1234 merged commit e17472e into arduino:main Jul 26, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants