fix: close monitor if port changed during upload

the client will automatically request a new monitor with the new port
arduino · Aug 14, 2023 · 76d46d4 · 76d46d4
1 parent 97f1801
commit 76d46d4
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/arduino-ide-extension/src/node/monitor-manager.ts b/arduino-ide-extension/src/node/monitor-manager.ts
@@ -8,6 +8,7 @@ import {
   PluggableMonitorSettings,
   Port,
   PortIdentifier,
+  portIdentifierEquals,
 } from '../common/protocol';
 import { CoreClientAware } from './core-client-provider';
 import { MonitorService } from './monitor-service';
@@ -214,7 +215,11 @@ export class MonitorManager extends CoreClientAware {
 
     const monitor = this.monitorServices.get(beforeMonitorID);
     if (monitor) {
-      await monitor.start();
+      if (portIdentifierEquals(beforePort, afterPort)) {
+        await monitor.start();
+      } else {
+        await monitor.stop();
+      }
     }
 
     // this monitorID will only be present in "disposedForUpload"