Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy: build options refinements #2343

Closed
wants to merge 2 commits into from

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 26, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Slight simplification of the builder's BuildOptions struct.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie self-assigned this Sep 26, 2023
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself criticality: low Of low impact labels Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c004b42) 63.10% compared to head (29bf461) 63.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2343      +/-   ##
==========================================
- Coverage   63.10%   63.02%   -0.09%     
==========================================
  Files         201      201              
  Lines       19262    19260       -2     
==========================================
- Hits        12155    12138      -17     
- Misses       6056     6067      +11     
- Partials     1051     1055       +4     
Flag Coverage Δ
unit 63.02% <50.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
arduino/builder/builder.go 71.42% <100.00%> (ø)
arduino/builder/build_options_manager.go 81.72% <46.15%> (-0.39%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie
Copy link
Member Author

cmaglie commented Sep 29, 2023

After discussing this PR with my colleagues, we decided to not merge it and use a different approach.

@cmaglie cmaglie closed this Sep 29, 2023
@cmaglie cmaglie deleted the build_options_refinements branch September 29, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: low Of low impact topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants