bugfix: excessive CPU/Disk usage when multiple build-paths points in the sketch directory #2342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Reduce CPU and disk consumption if multiple build paths are created in the sketch directory.
What is the current behavior?
See #2266 for details, for example running a build using the build-path to multiple subdirs of the sketch:
results in:
What is the new behavior?
The sketch is compiled as expected:
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
It's worth noting that the compiled sketch is not broken, it just takes more resources/time to compile.
Fix #2266