-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip-changelog] Check if a dependency matches the constraint when --no-overwrite
flag is set
#2331
[skip-changelog] Check if a dependency matches the constraint when --no-overwrite
flag is set
#2331
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2331 +/- ##
==========================================
+ Coverage 63.03% 63.11% +0.08%
==========================================
Files 201 201
Lines 19264 19284 +20
==========================================
+ Hits 12143 12172 +29
+ Misses 6067 6060 -7
+ Partials 1054 1052 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
string version_required = 2; | ||
// Version of the library dependency currently installed. | ||
string version_installed = 3; | ||
// Version constraint of the dependency. | ||
string version_constraint = 4; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version_constraint
seems redundant here, why do we need a version_constraint
if we already have a version_required
?
I mean if we have, say:
version_required: 1.2.3
version_contraint: >=1.2.0 && <2.0.0
version 1.2.3
is already the solution and matches the version_constraint
.
Superseded by #2431 |
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Code imperfection fix
What is the current behavior?
Installing a library with
--no-overwrite
fails if one of its dependency is already installed but outdated, even if it stills matches the version constraint.What is the new behavior?
Installing a library with
--no-overwrite
does not try to upgrade the library's dependencies if their version matches the constraint, preventing the installation from failing.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information