[skip-changelog] Check if a dependency matches the constraint when --no-overwrite flag is set
#2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
topic: code
3 tasks
MatteoPologruto
requested review from
cmaglie,
alessio-perugini and
umbynos
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2331 +/- ##
==========================================
+ Coverage 63.03% 63.11% +0.08%
==========================================
Files 201 201
Lines 19264 19284 +20
==========================================
+ Hits 12143 12172 +29
+ Misses 6067 6060 -7
+ Partials 1054 1052 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cmaglie
reviewed
Sep 27, 2023
Comment on lines
132
to
137
| string version_required = 2; | ||
| // Version of the library dependency currently installed. | ||
| string version_installed = 3; | ||
| // Version constraint of the dependency. | ||
| string version_constraint = 4; | ||
| } |
There was a problem hiding this comment.
version_constraint seems redundant here, why do we need a version_constraint if we already have a version_required?
I mean if we have, say:
version_required: 1.2.3
version_contraint: >=1.2.0 && <2.0.0
version 1.2.3 is already the solution and matches the version_constraint.
|
Superseded by #2431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Code imperfection fix
What is the current behavior?
Installing a library with
--no-overwritefails if one of its dependency is already installed but outdated, even if it stills matches the version constraint.What is the new behavior?
Installing a library with
--no-overwritedoes not try to upgrade the library's dependencies if their version matches the constraint, preventing the installation from failing.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information