Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy: Builder refactorization (part 5...) #2312

Merged
merged 34 commits into from
Sep 15, 2023

Conversation

alessio-perugini
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 78.83% and project coverage change: -0.27% ⚠️

Comparison is base (8c81d2c) 63.93% compared to head (1239ab2) 63.66%.

❗ Current head 1239ab2 differs from pull request most recent head 6004057. Consider uploading reports for the commit 6004057 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2312      +/-   ##
==========================================
- Coverage   63.93%   63.66%   -0.27%     
==========================================
  Files         212      204       -8     
  Lines       19873    19735     -138     
==========================================
- Hits        12705    12564     -141     
- Misses       6080     6082       +2     
- Partials     1088     1089       +1     
Flag Coverage Δ
unit 63.66% <78.83%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
arduino/builder/export_cmake.go 7.98% <20.00%> (ø)
arduino/builder/sizer.go 47.59% <55.55%> (ø)
arduino/builder/linker.go 77.33% <66.66%> (-2.19%) ⬇️
arduino/builder/recipe.go 76.31% <71.42%> (ø)
arduino/builder/core.go 73.84% <73.58%> (-2.80%) ⬇️
arduino/builder/sketch.go 65.67% <74.07%> (+7.98%) ⬆️
arduino/builder/build_options_manager.go 79.79% <79.79%> (ø)
legacy/builder/test/helper_tools_downloader.go 60.80% <80.00%> (ø)
arduino/builder/builder.go 82.97% <84.72%> (-3.69%) ⬇️
arduino/builder/libraries.go 81.25% <87.38%> (+2.25%) ⬆️
... and 6 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini force-pushed the refactor_legacy_part5 branch 6 times, most recently from ae555b4 to da308d8 Compare September 12, 2023 16:24
@alessio-perugini alessio-perugini added the topic: code Related to content of the project itself label Sep 12, 2023
@alessio-perugini alessio-perugini force-pushed the refactor_legacy_part5 branch 2 times, most recently from ffc946e to 4cb3c90 Compare September 12, 2023 18:50
@alessio-perugini alessio-perugini changed the title [skip-changelog] legacy: refactor (part 5) [skip-changelog] legacy: builder refactorization (part 5) Sep 12, 2023
@alessio-perugini alessio-perugini marked this pull request as ready for review September 12, 2023 19:26
@alessio-perugini alessio-perugini force-pushed the refactor_legacy_part5 branch 2 times, most recently from f09a475 to 1239ab2 Compare September 13, 2023 09:27
@alessio-perugini alessio-perugini self-assigned this Sep 14, 2023
@alessio-perugini alessio-perugini changed the title [skip-changelog] legacy: builder refactorization (part 5) legacy: Builder refactorization (part 5...) Sep 15, 2023
arduino/builder/builder.go Outdated Show resolved Hide resolved
arduino/builder/build_options_manager.go Show resolved Hide resolved
commands/compile/compile.go Show resolved Hide resolved
arduino/builder/preprocess_sketch.go Outdated Show resolved Hide resolved
@alessio-perugini alessio-perugini merged commit 9c073c1 into master Sep 15, 2023
179 checks passed
@alessio-perugini alessio-perugini deleted the refactor_legacy_part5 branch September 15, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants