Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed weird error message in core install if invalid platform is spcified #2309

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 11, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fixed an error message.

What is the current behavior?

$ arduino-cli core install asdasd:asdasd
Invalid argument passed: Found 0 platform for reference "asdasd:asdasd":

What is the new behavior?

$ arduino-cli core install asdasd:asdasd
Invalid argument passed: Platform 'asdasd:asdasd' not found

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: CLI Related to the command line interface labels Sep 11, 2023
@cmaglie cmaglie added this to the Arduino CLI 0.35.0 milestone Sep 11, 2023
@cmaglie cmaglie self-assigned this Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (65915d8) 63.82% compared to head (8c55dd5) 63.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2309      +/-   ##
==========================================
- Coverage   63.82%   63.82%   -0.01%     
==========================================
  Files         214      214              
  Lines       19794    19793       -1     
==========================================
- Hits        12633    12632       -1     
  Misses       6073     6073              
  Partials     1088     1088              
Flag Coverage Δ
unit 63.82% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
arduino/errors.go 26.85% <100.00%> (-0.77%) ⬇️
internal/cli/arguments/reference.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit cf5db1b into arduino:master Sep 11, 2023
92 checks passed
@cmaglie cmaglie deleted the fixed_message branch September 11, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: CLI Related to the command line interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants