Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy: refacored makeSourceFile / other minor code moved #2303

Merged
merged 5 commits into from
Sep 8, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 8, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

refacored makeSourceFile / other minor code moved

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie changed the title legacy: refacored makeSourceFile / other minor code moved legacy: refacored makeSourceFile / other minor code moved Sep 8, 2023
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 8, 2023
@cmaglie cmaglie self-assigned this Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 85.91% and no project coverage change.

Comparison is base (b8024c3) 63.82% compared to head (17defc8) 63.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2303   +/-   ##
=======================================
  Coverage   63.82%   63.82%           
=======================================
  Files         214      214           
  Lines       19794    19794           
=======================================
  Hits        12633    12633           
+ Misses       6074     6073    -1     
- Partials     1087     1088    +1     
Flag Coverage Δ
unit 63.82% <85.91%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
arduino/builder/sketch.go 48.95% <ø> (-5.36%) ⬇️
legacy/builder/create_cmake_rule.go 8.30% <0.00%> (ø)
legacy/builder/test/helper_tools_downloader.go 60.80% <0.00%> (ø)
arduino/builder/builder.go 85.18% <82.60%> (-14.82%) ⬇️
arduino/builder/detector/detector.go 74.56% <89.47%> (-0.06%) ⬇️
arduino/builder/utils/utils.go 76.49% <100.00%> (ø)
commands/compile/compile.go 71.34% <100.00%> (-0.09%) ⬇️
legacy/builder/merge_sketch_with_bootloader.go 75.70% <100.00%> (ø)
legacy/builder/phases/core_builder.go 77.77% <100.00%> (ø)
legacy/builder/phases/libraries_builder.go 80.37% <100.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 65915d8 into arduino:master Sep 8, 2023
92 checks passed
@cmaglie cmaglie deleted the refactor_legacy_phases_2 branch September 8, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants