Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vscode config to fix bogus protoc compiler import errors #2278

Closed
wants to merge 1 commit into from

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Aug 24, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Adds a config file for vscode to fix bogus compiler import errors.

What is the current behavior?

image

What is the new behavior?

image

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Aug 24, 2023
@cmaglie cmaglie self-assigned this Aug 24, 2023
@cmaglie cmaglie changed the title Added vscode config to fix protoc compiler import errors Added vscode config to fix bogus protoc compiler import errors Aug 24, 2023
@alessio-perugini
Copy link
Contributor

I'm not a vscode user, so my opinion on this sticks with my general preference to be editor agnostic. If we want to remain agnostic, I'd create a doc that can give some tips on how to make some functions work for some IDE.

@cmaglie
Copy link
Member Author

cmaglie commented Aug 24, 2023

I see, I'll keep the gitignore and see how it goes, my config should stay there without any drawback.

@cmaglie cmaglie closed this Aug 24, 2023
@cmaglie cmaglie deleted the vscode_protoc branch August 24, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants