Fixed nil pointer excpetion in upload (#2548)

arduino · Feb 21, 2024 · 870a48f · 870a48f
1 parent 65fb6e5
commit 870a48f
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 1 deletion.
diff --git a/commands/upload/upload.go b/commands/upload/upload.go
@@ -150,7 +150,7 @@ func Upload(ctx context.Context, req *rpc.UploadRequest, outStream io.Writer, er
 	if programmer == "" && pme.GetProfile() != nil {
 		programmer = pme.GetProfile().Programmer
 	}
-	if programmer == "" {
+	if programmer == "" && sk != nil {
 		programmer = sk.GetDefaultProgrammer()
 	}
 

diff --git a/internal/integrationtest/upload_mock/upload_mock_test.go b/internal/integrationtest/upload_mock/upload_mock_test.go
@@ -726,3 +726,44 @@ func generateBuildDir(sketchPath *paths.Path, t *testing.T) *paths.Path {
 	require.NoError(t, buildDir.ToAbs())
 	return buildDir
 }
+
+func TestUploadWithInputDirFlag(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("core", "install", "arduino:mbed_opta")
+	require.NoError(t, err)
+
+	sketchPath := cli.SketchbookDir().Join("TestSketchForUpload")
+	_, _, err = cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+
+	// Create a fake build directory
+	buildDir := sketchPath.Join("build")
+	require.NoError(t, buildDir.MkdirAll())
+	require.NoError(t, buildDir.Join("TestSketchForUpload.ino.bin").WriteFile(nil))
+	require.NoError(t, buildDir.Join("TestSketchForUpload.ino.elf").WriteFile(nil))
+	require.NoError(t, buildDir.Join("TestSketchForUpload.ino.hex").WriteFile(nil))
+	require.NoError(t, buildDir.Join("TestSketchForUpload.ino.map").WriteFile(nil))
+
+	// Test with input-dir flag
+	_, _, err = cli.Run(
+		"upload",
+		"-b", "arduino:mbed_opta:opta",
+		"-i", buildDir.String(),
+		"-t",
+		"-p", "/dev/ttyACM0",
+		"--dry-run", "-v",
+		sketchPath.String())
+	require.NoError(t, err)
+
+	// Test with input-dir flag and no sketch
+	_, _, err = cli.Run(
+		"upload",
+		"-b", "arduino:mbed_opta:opta",
+		"-i", buildDir.String(),
+		"-t",
+		"-p", "/dev/ttyACM0",
+		"--dry-run", "-v")
+	require.NoError(t, err)
+}