-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump linux-odroid-xu3 to current 6.6.y branch #2027
Conversation
ecd0d69
to
49fc7bc
Compare
49fc7bc
to
1ec9e34
Compare
1ec9e34
to
36976d7
Compare
@graysky2, any chance this could get a review? |
For one, your PR violates the rules for PR. Why are you touching multiple packages? For two, I don't know why upstream hasn't modified their fork of the kernel. If it like's their support for the C2, there is not an upgrade path. Further, I don't have this hardware for testing and if you do, you haven't indicated any functional status of the kernel package on the hardware. |
TIL. Might be good to setup https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors
Figured linux-armv7 and linux-odroid-xu3 are similar enough that I could help shake the cobwebs off that as well. Rebasing in preparation of building 6.6.36, and I see you've bumped linux-armv7. Great! Shame you didn't build off the consistency fixes that were in this MR. Can drop the minor consistency fixes for linux-aarch64 as well.
I don't follow.
Ah yes, of course I've been using this for some time now 😄. Output over HDMI seems to work fine still. Anything in particular I should test? |
Worth noting that prior to a recent change steming from mkinitcpio, one could get on with the currently packaged |
Please scope the PR to just one PKGBUILD, as your title indicates,
I mean that upstream's (hardkernel) fork of the linux kernel has not been updated since 4.14.180. They pulled this shit with the ODROID-C2 as well. I want to make sure whatever changes are needed to modernize the kernel are vetted/tested by someone who owns the hardware. Which branch are thinking is tracking 6.6.y that is specific to this hardware? Just browsing, I see: https://github.com/hardkernel/linux/tree/odroid-6.6.y but I haven't dug into it looking for specific changes for the XU3. Have all been mainlined? Is there a reason to carry a separate kernel for this hardware any more? |
Will do, after I try 6.6.36 shortly. Finally setup distcc (thanks for your AUR package btw). I was building under QEMU which takes like a day 😅.
You can see some of the changes specific to the hardware here (fairly certain there are more, but it only gives you the page): The only thing I specifically know is needed is a change to the thermal throttling code, as the sensors on the XU3 tend to be faulty. Learned of this branch after noticing this comment: |
Good that they are keeping their fork active. Yes, distcc is a good option but a better one particularly for the kernel as it is self-contained is cross compiling on x86_64 assuming you have a powerful box running Arch. I just updated the AUR packages for the cross compiler. If you'd rather not build them, I can provide you with the versions I built. Once installed, building is as simple as:
|
On July 4, 2024 5:13:19 PM EDT, graysky ***@***.***> wrote:
Good that they are keeping their fork active.
Yes, distcc is a good option but a better one particularly for the kernel as it is self-contained is cross compiling on x86_64 assuming you have a powerful box running Arch. I just updated the [AUR packages](https://aur.archlinux.org/packages?O=0&SeB=nd&K=armv7l) for the cross compiler. If you'd rather not build them, I can provide you with the versions I built. Once installed, building is as simple as:
```
% CARCH=armv7h ARCH=arm CROSS_COMPILE=armv7l-unknown-linux-gnueabihf- nice -19 makepkg -sCAfd
```
Was wondering how to do that. Thanks, will try it out.
…--
Best,
Daniel <https://danielcapella.com>
|
36976d7
to
ee346d6
Compare
This MR only touches the linux-odroid-xu3 package now. |
Please squash into a single commit.
…On Thu, Jul 4, 2024 at 10:55 PM, Daniel M. Capella ***@***.***(mailto:On Thu, Jul 4, 2024 at 10:55 PM, Daniel M. Capella <<a href=)> wrote:
cpio also seems to be a makedep, as the build fails without it, at least with plain makepkg. Have not built in a clean chroot yet.
This MR only touches the linux-odroid-xu3 package now.
—
Reply to this email directly, [view it on GitHub](#2027 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAECSJRRIGAQQSA6JAO2DMTZKYDJFAVCNFSM6AAAAABFJ7NUOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBZHEYDEMZSGA).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
3449a7a
to
edb79c3
Compare
Done |
Thank you, and you can confirm that the latest commit:
|
- Config copied directly from https://github.com/hardkernel/linux/blob/23a9f755640b418d446ba6c4ad9c281f9cf65eeb/arch/arm/configs/odroidxu4_defconfig - Update config resulting from build Based on options used elsewhere in this repo. - Remove unneeded 60-linux.hook and 90-linux.hook - 60-linux.hook is redundant as 60-depmod.hook provided by kmod handles it - 90-linux.hook is redundant and causes mkinitcpio to run twice under certain circumstances so instead, simply write a 0-byte file to trigger 90-mkinitcpio-install.hook from mkinitcpio. Reflects change from 0f2bbe5 - Consistency fixes Bring linux-odroid-xu3 more in line with the linux-aarch64 package.
edb79c3
to
bfc9b67
Compare
I think you made a misake ... your recent commit is hitting another package |
What stands out so far: New kernel:
Also there are less video devices registered: New kernel:
Old kernel:
The actual commit is just touching the one package. The compare button is just showing the gnutls changes after I rebased on master again. |
cc @mdrjr in case you have any interest/input :D |
Not sure, but if this is functional now with a few minor flaws which could be corrected in future releases, I think putting it on a support LTS kernel from a deprecated is more important. Good job with this. |
@graysky2 @polyzen With this package my HC1 refuses to start up, please see attached |
@polyzen - any thoughts? missing some HC1 specific commits? |
No idea. Sorry to bug you @mdrjr, but you'd know best :p Seems this guy built 6.1.90 for his HC1, but did not mention if it worked. Could try modifying the pkgbuild to build against 6.1.90, and see if that works.. It's a different branch. Edit: TIL "Any OS for XU4 is fully compatible with the HC1", weird.. |
I have the same problem. Sorry I didn't mention it in ffaille/alarm-linux-odroid-xu3#1. I wanted to have a closer look, but then got swiped away by something else. |
Opened an issue upstream hardkernel/linux#437 |
@kyak - can you install the mainline linux package and see if that boots?
|
I could, and I will, but not earlier than next week.. |
@wickner-consid - which hardware please? XU3? |
Updated to linux-odroid-xu3:6.6.40, didn't come up aswell. Switched to linux-armv7 and it's up and running. Feels a little laggier on the ssh term, but so far all seems to be working over here. @graysky2 Sorry, been signed in into the wrong account, hardware is hc1. Can you please keep the other account out of this conversation? |
It's a pity this got merged so quick even when users report that this kernel refuses to boot. |
I've installed It drops me to emergency mode because it can't find P.S. It detects sd card as |
This PR was open for months before it was merged. The reports came after. Please help with hardkernel/linux#437 as opposed to being snarky here. |
No description provided.