Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade pyparted due to "unrelease" #2282

Closed
wants to merge 1 commit into from

Conversation

alan-barzilay
Copy link
Contributor

somehow and for some reason, pyparted 3.13 is no longer available in pypi only in its git repository. To deal with this I downgraded the version requirement and updated to >= instead of the == exact version match

  • This fix issue:

PR Description:

Tests and Checks

  • I have tested the code!

somehow and for some reason,pyparted 3.13 is no longer available in pypi only in its git repository. To deal with this I downgraded the version requirement and updated to >= instead of the == exact version match
@alan-barzilay
Copy link
Contributor Author

@Torxed
Copy link
Member

Torxed commented Dec 4, 2023

If I recall correctly, we had issues with older versions of pyparted (libparted), so I'm wondering if this will maybe ensure that pyparted gets installed yes - but breaks calls later?

I'll have to verify this first.
Better odds are probably to get the packager of PyParted's attention and push the release as they should. It's a pretty minor thing as they only need to run ~1 command more or less.

@Torxed
Copy link
Member

Torxed commented Dec 6, 2023

Adding a cross reference to your issue for traceability: dcantrell/pyparted#106

@alan-barzilay
Copy link
Contributor Author

@Torxed , since it has been a few months and nothing happened on the pyparted side, could we move on with the downgrade here? I'm unable to use archinstall in production do to this..
If they release newer versions in the future we can still upgrade the requirement, the downgrade would be just a band-aid to fix the pip installation (which, as far as I understand, is fundamentally broken now) while pyparted does not break their inertia and start moving

@alan-barzilay
Copy link
Contributor Author

@Torxed up haha

@Torxed
Copy link
Member

Torxed commented May 9, 2024

I'm not closing this one just yet, but I have submitted a PR that could potentially replace this one. Instead of downgrading, I'm exploring just running around the problem completely. Because.. frustrations are a bit high atm with this dependency :P

@Torxed
Copy link
Member

Torxed commented May 9, 2024

Ok review went quick, closing this.
But if we bump into issues we can revisit this one.

@Torxed Torxed closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants