close the socket when disconnecting, cap at 6 hours for now

lib/archethic/p2p/client/connection.ex

@@ -445,6 +445,7 @@ defmodule Archethic.P2P.Client.Connection do
       ) do
     # disconnect if missed more than 2 heartbeats
     if heartbeats_sent - heartbeats_received >= 2 do
+      transport.handle_close(socket)
       {:next_state, :disconnected, data}
     else
       transport.handle_send(socket, "hb")
@@ -645,8 +646,8 @@ defmodule Archethic.P2P.Client.Connection do
         @reconnect_delay
 
       :exponential ->
-        # cap at 24hours
-        min(:timer.hours(24), 2 ** attempts * @reconnect_delay)
+        # cap at a few hours
+        min(:timer.hours(6), 2 ** attempts * @reconnect_delay)
     end
   end
 end

lib/archethic/p2p/client/transport.ex

@@ -4,4 +4,5 @@ defmodule Archethic.P2P.Client.Transport do
   @callback handle_connect(:inet.ip_address(), :inet.port_number()) :: {:ok, :inet.socket()}
   @callback handle_message(tuple()) :: {:ok, binary()} | {:error, :closed} | {:error, any()}
   @callback handle_send(:inet.socket(), binary()) :: :ok
+  @callback handle_close(:inet.socket()) :: :ok
 end

lib/archethic/p2p/client/transport/tcp_impl.ex

@@ -20,6 +20,11 @@ defmodule Archethic.P2P.Client.Transport.TCPImpl do
     :gen_tcp.connect(ip, port, @options, 4000)
   end
 
+  @impl Transport
+  def handle_close(socket) do
+    :gen_tcp.close(socket)
+  end
+
   @impl Transport
   def handle_message({:tcp, socket, data}) do
     :inet.setopts(socket, active: :once)

test/archethic/p2p/client/connection_test.exs

@@ -89,6 +89,10 @@ defmodule Archethic.P2P.Client.ConnectionTest do
           {:error, :timeout}
         end
 
+        def handle_close(_socket) do
+          :ok
+        end
+
         def handle_send(_socket, <<0::32, _rest::bitstring>>), do: :ok
 
         def handle_message({_, _, _}), do: {:error, :closed}
@@ -124,6 +128,10 @@ defmodule Archethic.P2P.Client.ConnectionTest do
           {:error, :timeout}
         end
 
+        def handle_close(_socket) do
+          :ok
+        end
+
         def handle_send(_socket, <<0::32, _rest::bitstring>>), do: :ok
 
         def handle_message({_, _, _}), do: {:error, :closed}
@@ -172,6 +180,10 @@ defmodule Archethic.P2P.Client.ConnectionTest do
           {:ok, make_ref()}
         end
 
+        def handle_close(_socket) do
+          :ok
+        end
+
         def handle_send(_socket, _), do: :ok
 
         def handle_message({_, _, _}), do: {:error, :closed}
@@ -274,6 +286,10 @@ defmodule Archethic.P2P.Client.ConnectionTest do
           {:ok, make_ref()}
         end
 
+        def handle_close(_socket) do
+          :ok
+        end
+
         def handle_send(_socket, <<0::32, _rest::bitstring>>), do: :ok
         def handle_send(_socket, <<_::32, _rest::bitstring>>), do: {:error, :closed}
 
@@ -340,6 +356,10 @@ defmodule Archethic.P2P.Client.ConnectionTest do
           end
         end
 
+        def handle_close(_socket) do
+          :ok
+        end
+
         def handle_send(_socket, <<0::32, _rest::bitstring>>), do: :ok
 
         def handle_send(_socket, <<_::32, _rest::bitstring>>) do
@@ -579,6 +599,10 @@ defmodule Archethic.P2P.Client.ConnectionTest do
           end
         end
 
+        def handle_close(_socket) do
+          :ok
+        end
+
         def handle_send(_socket, "hb") do
           hb_count = :persistent_term.get(:hb_count, 0)
           :persistent_term.put(:hb_count, hb_count + 1)
@@ -621,6 +645,10 @@ defmodule Archethic.P2P.Client.ConnectionTest do
       {:ok, make_ref()}
     end
 
+    def handle_close(_socket) do
+      :ok
+    end
+
     def handle_send(_socket, "hb") do
       send(self(), {:tcp, make_ref(), "hb"})
       :ok
@@ -640,6 +668,10 @@ defmodule Archethic.P2P.Client.ConnectionTest do
       {:ok, make_ref()}
     end
 
+    def handle_close(_socket) do
+      :ok
+    end
+
     def handle_send(_socket, _), do: :ok
 
     def handle_message({_, _, _}), do: {:error, :closed}