Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add PeriodicFuture automated tests. #17

Merged
merged 1 commit into from
Jul 9, 2024
Merged

test: Add PeriodicFuture automated tests. #17

merged 1 commit into from
Jul 9, 2024

Conversation

Chralu
Copy link
Collaborator

@Chralu Chralu commented Jul 8, 2024

PeriodicFuture Completer<void> cancelCompleter parameter replaced by a Duration timeout

@Chralu
test: Add PeriodicFuture automated tests.
e90cd05 
PeriodicFuture `Completer<void> cancelCompleter` parameter replaced by a `Duration timeout`
@Chralu Chralu requested a review from redDwarf03 July 8, 2024 13:43
redDwarf03
redDwarf03 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@redDwarf03 redDwarf03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests ok with aeSwap

@redDwarf03 redDwarf03 merged commit 65e276c into main Jul 9, 2024
2 checks passed
@redDwarf03 redDwarf03 deleted the periodic_future branch July 9, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redDwarf03 redDwarf03 redDwarf03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chralu @redDwarf03