[Windows] Always get the non-truncated face name in the style editor and in the font picker #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moi15moi
commented
Aug 15, 2024
moi15moi
commented
Aug 15, 2024
moi15moi
commented
Aug 15, 2024
moi15moi
force-pushed
the
Get-the-right-family-name-on-Windows
branch
from
de57db5
to
692bed0
Compare
…e GDI, which truncates the face name to 31 characters. Because of this, some users like in libass/libass#710 may think they have retrieved the correct face name, but that is not the case. It use the same method has GetMSWFaceName to get the family name: https://github.com/wxWidgets/wxWidgets/blob/44068b5550bc82ac535e82680d158d3e03d7aa5f/src/msw/font.cpp#L269-L303
moi15moi
force-pushed
the
Get-the-right-family-name-on-Windows
branch
from
692bed0
to
db67a97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, wxFontEnumerator::GetFacenames and wxFont::GetFaceName use GDI, which truncates the face name to 31 characters. This PR affects the font selection in the style editor and in the font picker.
Because of this, some users like in libass/libass#710 may think they have retrieved the correct face name, but that is not the case.
Tested on Windows 7 (Version 6.1.7601) and Windows 10 (Version 10.0.19045.4780).