fix(vue,php): Problem about renaming a space #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zak39
added
backend
When we rename a space from plural to single (or inversely) all groups are bad renamed. Signed-off-by: Baptiste Fotia <[email protected]>
zak39
force-pushed
the
fix/rename-a-space-in-the-plural
branch
from
abefe48
to
569c896
Compare
zak39
added a commit
that referenced
this pull request
Mar 26, 2024
Add these Pull Requests : - #915 - #900 - #893 - #888 Signed-off-by: Baptiste Fotia <[email protected]>
This was referenced Mar 26, 2024
zak39
added a commit
to zak39/workspace
that referenced
this pull request
Apr 4, 2024
Add these Pull Requests : - arawa#915 - arawa#900 - arawa#893 - arawa#888 Signed-off-by: Baptiste Fotia <[email protected]> feat(service,share): Limit the search to members Limit the search to members of the same group except for specific groups. I splited the code in 2 classes : - GroupMembersOnlyChecker : To check if the checkbox for the "Allow apps to use the Share API" and check if groups are listed from the multiselect. - ShareMembersOnlyFilter : to get the members only the same group or excepted a few groups from the multiselect. Signed-off-by: Baptiste Fotia <[email protected]> fix(service): Check if the current user is present in groups excluded I forget to check if the current user is present in groups exlcluded before to filter the users list. Signed-off-by: Baptiste Fotia <[email protected]> chore(): remove a comment Signed-off-by: Baptiste Fotia <[email protected]> fix(share): Return users with common groups Return users with common groups. Except users belonging to groups listed in the drop-down list (`Settings > Share > Restrict users to only share with users in their groups > Ingore the following groups when cheking group membership`). Signed-off-by: Baptiste Fotia <[email protected]> style(php): Run composer cs:fix Signed-off-by: Baptiste Fotia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we rename a space from plural to single (or inversely) all groups are bad renamed.