Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP:Promethesu Metric Collect #813

Closed

Conversation

gongna-au
Copy link
Contributor

@gongna-au gongna-au commented Dec 30, 2023

What this PR does:
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Copy link

cr-gpt bot commented Dec 30, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Copy link

sonarcloud bot commented Dec 30, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: 82 lines in your changes are missing coverage. Please review.

Comparison is base (ac511fe) 40.00% compared to head (ea33f78) 40.68%.
Report is 9 commits behind head on master.

Files Patch % Lines
pkg/metrics/prometheus/prometheus.go 62.16% 54 Missing and 2 partials ⚠️
pkg/boot/discovery.go 0.00% 9 Missing ⚠️
pkg/config/model.go 0.00% 5 Missing ⚠️
pkg/metrics/metrics.go 73.33% 3 Missing and 1 partial ⚠️
pkg/runtime/runtime.go 0.00% 4 Missing ⚠️
pkg/executor/redirect.go 0.00% 2 Missing ⚠️
pkg/runtime/tx.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
+ Coverage   40.00%   40.68%   +0.67%     
==========================================
  Files         265      267       +2     
  Lines       26711    27119     +408     
==========================================
+ Hits        10686    11033     +347     
- Misses      14861    14919      +58     
- Partials     1164     1167       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gongna-au gongna-au changed the title Feature/promethesu/metric WIP:Promethesu Metric Collect Dec 30, 2023
@gongna-au gongna-au closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants