Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Type 'string[]' is not assignable to type 'string | I18nDictionary'. #926

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkbctrl
Copy link

@mkbctrl mkbctrl commented Sep 21, 2022

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

What changes did you make? (Give an overview)
Added string[] to I18nDictionary interface

Which issue (if any) does this pull request address?
#925

Is there anything you'd like reviewers to focus on?
No, not really

@aralroca
Copy link
Owner

@mkbctrl thanks for your contribution 👍

@aralroca
Copy link
Owner

Tests are failing in this line of code: https://github.com/aralroca/next-translate/blob/canary/src/transCore.tsx#L115 Would you please try to correct it? thanks!

@mkbctrl
Copy link
Author

mkbctrl commented Sep 22, 2022 via email

@mkbctrl
Copy link
Author

mkbctrl commented Oct 4, 2022

update: got super busy in my project, didn't forget about it. It's still on my todo

@aralroca aralroca changed the base branch from canary to master February 20, 2023 16:29
@aralroca
Copy link
Owner

@mkbctrl just a ping for this 👍 BTW; thanks for your contribution

@neila
Copy link

neila commented Sep 14, 2024

Is this being worked on? Experiencing the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants